Conversation
* Modified versioning and publishing of new releases to Pypi * Fixed duplicated line
Update pyproject.toml to define packages for setuptools...
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the Python package build and release process by migrating from legacy setup.py-based configuration to modern pyproject.toml standards and simplifying the CI/CD workflows. The changes align with current Python packaging best practices and implement trusted publishing to PyPI.
Key changes:
- Migrated packaging configuration from setup.py to pyproject.toml with setuptools-scm for automatic versioning
- Replaced complex version management workflows with a simple release-triggered build and publish workflow
- Updated package name from oscar_python to oscar-python and modernized dependency specifications
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | New packaging configuration file with modern Python packaging standards |
| setup.py | Simplified to minimal stub for backward compatibility |
| version.py | Removed in favor of automatic versioning via setuptools-scm |
| .github/workflows/release-build.yaml | Modernized workflow for building and publishing to PyPI on release |
| .github/workflows/release-version.yaml | Removed complex version management workflow |
| .github/workflows/tests.yaml | Extended to run tests on devel branch |
| README.md | Updated badges and package name references |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
* Fix dependencies problem and update tests * Updated version dependency * Updated tests action to employ environment dependencies * Fix development dependencies
SergioLangaritaBenitez
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/grycap/issue-tracker/issues/107
This pull request modernizes and simplifies the Python package build and release process, aligning it with current Python packaging standards and GitHub Actions best practices. The changes include migrating configuration to
pyproject.toml, streamlining the CI/CD workflows for building and publishing releases, and updating documentation and metadata to reflect the new package name and structure.Build and Release Workflow Modernization:
release-build.yamlworkflow with a new, standards-compliant workflow that builds and publishes the package to PyPI only when a GitHub release is published. The new workflow usespyproject.toml-based builds, uploads artifacts, and employs trusted publishing to PyPI. (.github/workflows/release-build.yaml)release-version.yamlworkflow, which previously handled version bumping and release creation, in favor of a simpler, more robust release process. (.github/workflows/release-version.yaml)Packaging Configuration Updates:
pyproject.tomlfile, specifying build system requirements, project metadata, dependencies, and setuptools-scm for automatic versioning from git tags. (pyproject.toml)setup.pyto a minimal stub for backward compatibility, delegating all configuration topyproject.toml. (setup.py)version.pyfile, as versioning is managed automatically by setuptools-scm. (version.py)Documentation and CI Improvements:
README.mdbadges and text to reflect the new package name (oscar-python), correct PyPI links, and display test status instead of the old build workflow. (README.md)develbranch, improving test coverage for development work. (.github/workflows/tests.yaml)